[Bug 447219] Review Request: ucview - Image and video capture application using unicap toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ucview - Image and video capture application using unicap toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=447219


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-05-19 04:13 EST -------
Thanks Patrice.

Review:
+ package builds in mock (development i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=616787
+ rpmlint is silent for SRPM But NOT for RPM.
ucview.i386: W: non-conffile-in-etc /etc/gconf/schemas/ucview.schemas
== Ok to ignore.
+ source files match upstream.
e241951a418db9bd66d8da612af15328  ucview-0.17.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are used correctly.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ scrollkeeper,Gconf2,gtk-update-icon-cache scriptlets are used.
+ Desktop file installed correctly.
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.