[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-05-19 14:07 EST -------
For 5.08.92-0:

* License
------------------------------------------------
Opcodes/Loris/		GPLv2+
examples/cscore/	GPLv2+
------------------------------------------------
  - Now libstdutil.so is also under LGPLv2+
    (also checked 2008-05-08 on ChangeLog)
    License tag can be "LGPLv2+" now.

* Compiler flags
------------------------------------------------
   164  gcc -o Engine/auxfd.os -c -O3 -mtune=k6 -DGNU_GETTEXT -DUSE_LRINT -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -g -fomit-frame-pointer -DLINUX -DPIPES
-fvisibility=hidden -fPIC -DHAVE_LIBSNDFILE=1016 -DBETA
-DENABLE_OPCODEDIR_WARNINGS=0 -DOLPC -DHAVE_SOCKETS -DHAVE_FCNTL_H
-DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H -DHAVE_SYS_TYPES_H
-DHAVE_TERMIOS_H -DHAVE_SOCKETS -DHAVE_DIRENT_H -D__BUILDING_LIBCSOUND -I. -IH
-I/usr/include/fltk-1.1 -I/usr/local/include -I/usr/include -I/usr/include
-I/usr/X11R6/include Engine/auxfd.c
------------------------------------------------
  - -fomit-frame-pointer is strictly forbidden for Fedora as
    this makes debugging almost impossible.

* Directory ownership issue
  - %_includedir/csound is not owned by any packages.

* rpmlint issue
------------------------------------------------
olpcsound.i386: E: description-line-too-long olpcsound is a subset of the Csound
sound and music synthesis system, tailored specifically for  XO platform.
------------------------------------------------
  - Please check $ rpmlint -I description-line-too-long

Then:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on:
http://fedoraproject.org/PackageReviewStatus/NEW.html
(NOTE: please don't choose "Merge Review")


Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.