[Bug 225708] Merge Review: dovecot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: dovecot


https://bugzilla.redhat.com/show_bug.cgi?id=225708


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul at city-fan.org




------- Additional Comments From paul at city-fan.org  2008-05-22 05:09 EST -------
Some comments on the current scriptlets.

1. In %post, the code to migrate the certificates from the old locations is
enclosed in a block that is only used on installs, not upgrades. Isn't the
entire point of the certificate-moving code to facilitate tidy upgrades?

2. Again in %post, the certificate and DH parameter generation is only done for
installs, not upgrades. But the certificates and DH parameters are only
generated if they don't already exist anyway, so it seems to me that the test
for "install, not upgrade" can be dispensed with entirely.

3. Why is the "service dovecot condrestart" in %postun rather than %post? When
upgrading from a version of dovecot prior to this one, the condrestart won't
happen (though it will for subsequent upgrades).

4. Again in %postun, the removal of the dovecot group and user should be
stripped out - the current packaging guidelines say not to remove
package-created users and groups
(http://fedoraproject.org/wiki/Packaging/UsersAndGroups). Similarly, in %pre,
the creation of the dovecot user account doesn't follow the currently prescribed
recipe (that includes the use of getent).




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.