[Bug 448215] Review Request: firefox-voikko - Finnish Voikko spell-checker extension for Firefox

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firefox-voikko - Finnish Voikko spell-checker extension for Firefox


https://bugzilla.redhat.com/show_bug.cgi?id=448215





------- Additional Comments From ville.skytta at iki.fi  2008-05-24 12:37 EST -------
I don't have F-9 yet so not taking the review at this point, but here's some
notes just from looking at the specfile and srpm:

- Source0 is not a full URL to the tarball.

- The %{_libdir}/mozilla/extensions/%{firefox_app_id} dir is not owned by this
package, is it owned by something else in its dependency chain?

- The Makefile patch hardcodes NSPR_INCLUDES=-I/usr/include/nspr4, I think it
could be changed to something like NSPR_INCLUDES=$(shell pkg-config
--cflags-only-I nspr)

- The Makefile patch hardcodes XULRUNNER_SDK=/usr/lib/xulrunner-sdk-1.9pre - is
that correct on lib64 archs too, and isn't there a pkg-config or something that
could be called like in the NSPR_INCLUDES comment above?  Ditto for
VOIKKO_INCLUDES by the way.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.