[Bug 444760] Review Request: obm - Open Business Management

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: obm - Open Business Management


https://bugzilla.redhat.com/show_bug.cgi?id=444760


fedora at famillecollet.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com




------- Additional Comments From fedora at famillecollet.com  2008-05-31 04:09 EST -------
First comments

>From rpmlint :
obm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 32)
=> minor and easy to fix

obm.noarch: E: non-standard-uid /var/www/obm apache
obm.noarch: E: non-standard-gid /var/www/obm apache
=> seems ok, but could probably be /var/lib/obm ?

obm.noarch: E: non-standard-uid /usr/share/obm apache
obm.noarch: E: non-standard-gid /usr/share/obm apache
=> really need to be fixed. Apache shouldn't have write acces here

>From obm-httpd.conf
ErrorLog & CustomLog & AddDefaultCharset should be in comment (for vhost use only)

>From obm documentation, some php_flag/value missing
php_value include_path ".:/usr/share/pear:/usr/share/php:/usr/share/obm"
php_flag session.bug_compat_42  Off
php_flag session.bug_compat_warn Off
php_flag magic_quotes_gpc On

Config should go to /etc/obm (probably an simple link in /usr/share/obm/conf)
A working obm_conf.inc & obm_conf.ini should be provided


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.