[Bug 448422] Review Request: trophy - Car racing game with special features

bugzilla at redhat.com bugzilla at redhat.com
Sat May 31 09:35:31 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: trophy - Car racing game with special features


https://bugzilla.redhat.com/show_bug.cgi?id=448422





------- Additional Comments From dan at danny.cz  2008-05-31 05:35 EST -------
formal review:

OK	source files match upstream:
	    11fbf36691e4db909d7a641daa8e5983431ce6f0  trophy-1.1.5.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (GPL). License text included in package.
OK	latest version is being packaged.
BAD	BuildRequires are proper - ClanLib-devel is missing
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64)
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets for updating the icon cache are present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app, desktop file is installed

=> only the BR: needs fixing
 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list