[Bug 471809] Review Request: gnome-gmail-notifier - A simple application that monitors Gmail inboxes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471809


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-11-16 23:38:57 EDT ---
Need some work
1) remove vendor tag as per
https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor
  I see some warnings also for desktop file but its ok. You can check those
warnings in build log or output of desktop-file-validate

2) also you can remove original desktop file along with above fix as
from 
rm %{buildroot}%{_datadir}/applications/%{name}.desktop
desktop-file-install --vendor="fedora"
--dir=%{buildroot}%{_datadir}/applications data/%{name}.desktop
to
desktop-file-install                                    \
--delete-original                                       \
--dir=%{buildroot}%{_datadir}/applications              \
%{buildroot}/%{_datadir}/applications/%{name}.desktop

3) preserve timestamps by using make install as
make install DESTDIR=%{buildroot} INSTALL="install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.