[Bug 469514] Review Request: debmirror - debian partial mirror script

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469514





--- Comment #4 from Itamar Reis Peixoto <itamar at ispbrasil.com.br>  2008-11-01 16:25:52 EDT ---
I belive the correct license tag should be GPLv2, also take a look on rpmlint
message about Misc group.


rpmlint /usr/src/redhat/RPMS/noarch/debmirror-20070123-1.fc9.noarch.rpm
debmirror.noarch: W: non-standard-group Misc
debmirror.noarch: W: invalid-license GPL
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


I belive all files in debian dir should be installed as %doc, including
doc/design.txt

look
https://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files

and Why you don`t install debmirror.conf in %{_sysconfdir} using
%config(noreplace) ? also why you have included a patch moving this file to
$HOME ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.