[Bug 459855] Review Request: ncid - Caller ID distributed over a network to a variety of devices
bugzilla at redhat.com
bugzilla at redhat.com
Mon Nov 3 03:21:04 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459855
--- Comment #5 from Eric Sandeen <esandeen at redhat.com> 2008-11-02 22:21:03 EDT ---
Oh, also:
> Another observation:
> Why did you remove the shebang line from the ncidrotate-script? If it's
> supposed to be executable, drop it in /usr/libexec/%{name}/.
It really isn't executable, it's just sourced by... er... another script which
isn't packaged or installed. Grr. I should just install ncidd.logrotate and
remove the other one.
Regarding initscripts, I have a least one other package w/ initscripts, I'll
probably convert all to upstart when appropriate and when I have some time.
I'll have to check on the cidcall.log issue; ISTR that the daemon didn't
properly create it if it didn't already exist (maybe even failed to start), and
make install touches it:
install-log:
touch $(CALLLOG)
so... *shrug* I could echo something into it to shut up rpmlint ;)
I have to say that the package itself isn't particularly tidy... I may consider
trying to get some of these fixes upstream before I decide that I really want
to maintain this in fedora ... I've been using it at home though, and it does
seem reasonably functional & useful, at least :)
Thanks,
-Eric
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list