[Bug 469273] Review Request: quickfix - development library for FIX based applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469273


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp
            Summary|Review Request: QuickFIX -  |Review Request: quickfix -
                   |development library for FIX |development library for FIX
                   |based applications          |based applications




--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-08 13:22:48 EDT ---
For 1.12.4-3:

!   You can make your spec file based on the skeleton spec file
    created by 
    $ rpmdev-newspec -t lib quickfix

* Group
  - Usually main package of this type has "Group: System Environment/Libraries"

* License
---------------------------------------------
src/C++/FlexLexer.h  BSD with advertising
src/C++/strptime.c  BSD with advertising
src/getopt.c   BSD with advertising
---------------------------------------------
  - The license tag must be "ASL 1.1 and BSD with advertising"

* SourceURL
  - For sourceforge hosted source tarball, please refer to
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* BuildRequires
  - Remove all redundant (unneeded) BuildRequires.
  ! "libtool,autoconf,automake" are not needed because
    no autotools are called
  ! "zlib libxml2" are not needed because the corresponsing -devel
    packages are in BuildRequires

* Dependency for -devel subpackage
  - -devel subpackage must have "Requires: %{name} = %{version}-%{release}"
    (see: "MUST: In the vast majority of cases, devel ... of
     https://fedoraproject.org/wiki/Packaging/ReviewGuidelines )

* Parallel make
  https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
  - Support parallel make if possible. If this package does not
    support parallel make write in the spec file as comments
    that this package does not support it.

* Compiler flags
----------------------------------------------
   410  + make
   411  make  all-recursive
   412  make[1]: Entering directory `/builddir/build/BUILD/quickfix'
   413  Making all in src
   414  make[2]: Entering directory `/builddir/build/BUILD/quickfix/src'
   415  Making all in C++
   416  make[3]: Entering directory `/builddir/build/BUILD/quickfix/src/C++'
   417  Making all in test
   418  make[4]: Entering directory
`/builddir/build/BUILD/quickfix/src/C++/test'
   419  if /bin/sh ../../../libtool --mode=compile g++ -DHAVE_CONFIG_H -I. -I.
-I../../.. -I..    -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -Wall -ansi -Wpointer-arith -Wwrite-strings     
-I/usr/include/libxml2    -O0 -g -MT FieldBaseTestCase.lo -MD -MP -MF
".deps/FieldBaseTestCase.Tpo" \
   420            -c -o FieldBaseTestCase.lo `test -f 'FieldBaseTestCase.cpp'
|| echo './'`FieldBaseTestCase.cpp; \
   421          then mv ".deps/FieldBaseTestCase.Tpo"
".deps/FieldBaseTestCase.Plo"; \
   422          else rm -f ".deps/FieldBaseTestCase.Tpo"; exit 1; \
   423          fi
----------------------------------------------
  - Fedora uses "-O2" compiler flags (, which can be checked by
    $ rpm --eval %optflags ), which is replaced by the latter "-O0",
    which needs fixing.

* %files entry
  - There are some packaging issues about %files entry
    * %_libdir/libquickfix.so.10 must included in main package
    * %_libdir/libquickfix.so must be in -devel package
    * %_libdir/*.a _must_ not be packaged:
     
https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries

  ! Usually with Makefiles generated by recent autotools 
    files can be correctly installed with
-------------------------------------------------------
make DESTDIR=%{buildroot} install
-------------------------------------------------------
    However this package does not support DESTDIR=..., 
    so using %makeinstall is preferable (although this must
    usually be avoided as written on
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
    ) 
    than installing files manually by "cp -a" as you are
    doing now (the latter method may cause make mistakes much
    more than using %makeinstall)

    When using %makeinstall, please also note in the spec file
    that this package does not DESTDIR.

* Duplicate files
  - Many files are listed twice:
-------------------------------------------------------
  1173  Processing files: quickfix-debuginfo-1.12.4-3.fc10
  1174  Processing files: quickfix-devel-1.12.4-3.fc10
  1175  warning: File listed twice: /usr/include/quickfix/Acceptor.h
  1176  warning: File listed twice: /usr/include/quickfix/Application.h
  1177  warning: File listed twice: /usr/include/quickfix/CallStack.h
  1178  warning: File listed twice: /usr/include/quickfix/ConfigLexer.h
.................
-------------------------------------------------------
   Note that the %files entry
-------------------------------------------------------
%files
%{_includedir}/quickfix
-------------------------------------------------------
   contains the directory %_includedir/quickfix itself _and_ all
   files/directories/etc under %_includedir/quickfix.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.