[Bug 464050] Package Review Request for projectM-libvisual

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464050


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orcanbahri at yahoo.com
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #5 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-08 13:33:47 EDT ---
* URL needs corrected

Thanks for updating the SPEC, addressing common issues with other packages.
Here are my notes for this one:

* Again, the licensing of this one is a disaster. Any replies from upstream
yet?
   ConfigFile.h is MIT
   COPYING is GPLv2+
   lvtoprojectM.h LGPLv2+

The source file actor_projectM.cpp does not have any license indicated, hence
we should assume that one is what the COPYING file says. Then the final license
should be (until there is a clarification by upstream)
   License: LGPLv2+ and GPLv2+ and MIT
What do you think?

* %{_libdir}/libvisual-0.4/actor/ is owned by libvisual-plugins. Rpmbuild does
not pick up this dependency. Please check whether projectM-libvisual depends on
libvisual-plugins. If yes, explicitly require libvisual-plugins. If no, own the
directory %{_libdir}/libvisual-0.4/actor/ .

* You should get rid of the commented out lines unless there's a reason (e.g.
if it is an explanation for a command, patch etc.)



# Just a general reminder. When you put a (build-)dependency like
   BR: libprojectM-devel = %{version} ?
this package will not build if there is an upstream update to libprojectM-devel
but no update is made to this one. Then you will need to come back to this
package and update the BR. It is fine to do so, but keep in mind that you can
also use ">=" instead of "=", to save some work.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.