[Bug 225897] Merge Review: ImageMagick

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225897





--- Comment #12 from Hans de Goede <hdegoede at redhat.com>  2008-11-14 09:56:55 EDT ---
(In reply to comment #1)
> I reviewed ImageMagick. It needs some work to yield the guidelines:
> 

Thanks,

Below is my response to items which I did not address the rest is fixed in the
latest release which you can find here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=933562

> * Packages must NOT contain any .la libtool archives, these should be removed
> in the spec. In my mock build the current ImageMagick rpm contains .la files in
>    /usr/lib64/ImageMagick-6.4.0/modules-Q16/coders/
> 


The .la files are still needed, see bug 185237, also as these are not in the
standard library path, so they can do no harm.

> Afaik, this one is not supported anymore, can be removed:
>    BuildRequires: libungif-devel
> 


That is not true, libungif was a patent free *drop in* replacement for giflib,
now that the patent is no longer valid we use giflib again, and giflib-devel
provides libungif-devel, so this BR drags in giflib-devel, I've changed it to
directly BR giflib-devel

> * Is there a particular reason why you don't Require:
> libpng-devel,libtiff-devel,libwmf-devel,libxml2-devel in the -devel package?
> 

Because non of the ImageMagick headers use headers from these packages, it
would be nice if you would check such things yourself before making comments
like this in a review. Usually the reviewer does this the other way around he
checks which headers from other packages the headers need, and if they are all
Required by the -devel package.

> * You might want to use the "--enable_static=no" flag for faster compilation.
> This might also save some lines (from the SPEC) file dedicated to removing the
> static libraries.

I assume you mean --disable-static, done.

> * Adding djvu and jbig supports will be nice (although not necessary).
> 

jbig is patented and thus not included in Fedora

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.