[Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455581


Chris Weyl <cweyl at alumni.drew.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |cweyl at alumni.drew.edu
               Flag|                            |fedora-review+




--- Comment #7 from Chris Weyl <cweyl at alumni.drew.edu>  2008-11-18 11:55:58 EDT ---
The code is explicitly licensed under 2.01 of the PHP License, which indicates
that it can be used under the terms of that license or "any future version of
this license."

Spec looks sane, clean and consistent; license is correct (PHP); make test
passes cleanly.  Package complies with PHP-specific guidelines.

Koji scratch build looks good.

Sources match upstream:

95bdbd6a9a0d14cb65c6d6bdc9ee1770  ssh2-0.10.tgz
95bdbd6a9a0d14cb65c6d6bdc9ee1770  ssh2-0.10.tgz.srpm

Final provides/requires looks sane:

** php-pecl-ssh2-0.10-2.fc11.x86_64.rpm
== rpmlint
== provides
config(php-pecl-ssh2) = 0.10-2.fc11
php-pecl(ssh2) = 0.10
ssh2.so()(64bit)  
php-pecl-ssh2 = 0.10-2.fc11
php-pecl-ssh2(x86-64) = 0.10-2.fc11
== requires
/bin/sh  
/bin/sh  
/usr/bin/pecl  
/usr/bin/pecl  
config(php-pecl-ssh2) = 0.10-2.fc11
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libssh2.so.1()(64bit)  
php(api) = 20041225
php(zend-abi) = 20060613
rtld(GNU_HASH)  
** php-pecl-ssh2-debuginfo-0.10-2.fc11.x86_64.rpm
== rpmlint
== provides
php-pecl-ssh2-debuginfo = 0.10-2.fc11
php-pecl-ssh2-debuginfo(x86-64) = 0.10-2.fc11
== requires

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.