[Bug 472165] Review Request: perl-Test-Strict - Check syntax, presence of use strict/warnings, and test coverage
bugzilla at redhat.com
bugzilla at redhat.com
Wed Nov 19 09:24:36 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=472165
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2008-11-19 04:24:34 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=939617
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
34837b2bfabf73f7169bbfa4d00a403c Test-Strict-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=26, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.19 cusr 0.02
csys = 0.24 CPU)
+ Package perl-Test-Block-0.11-1.fc11
Provides: perl(Test::Block) = 0.11 perl(Test::Block::Plan)
Requires: perl(Carp) perl(Scalar::Util) perl(Test::Builder) perl(Tie::Scalar)
perl(base) perl(overload) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list