[Bug 471575] Review Request: libnautilus-vcards - Nautilus vcard context menu extension

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471575


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-11-19 05:49:18 EDT ---
Just some quick comment on your spec file

- remove the redundant stuff
  - %define version 0.2 -> Version: 0.2, later you can use %{version}. This is
done automatically.
  - remove pkg (this is the macro %{name} ), url, and the dir stuff. The spec
file will be much more readable. For almost all your entires exists a macro:
  
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros

- Release: %{svnversion}%{?dist} . This means the release of the spec file not
the version of the software.  In your case this is '1' at the moment.  More
details about the naming
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release

- URL should point to the project's website
  http://sourceforge.net/projects/dt-contacts/

- BuildRoot: Samples at
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- For translations is 'BR: gettext' sufficient.  'BuildRequires: gettext-devel'
is not needed
  https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files

- Replace '%defattr(-, root, root, 0755)' with '%defattr(-, root, root, -)'

- add ABOUT-NLS to %doc

- Is 'mkdir -p $RPM_BUILD_ROOT' needed in the %install section?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.