[Bug 461454] Review Request: lordsawar - Turn-based strategy game in a fantasy setting

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 22 20:01:23 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461454


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Michael Schwendt <bugs.michael at gmx.net>  2008-11-22 15:01:21 EDT ---
I'm inclined to say "let's make this a test update at least".
It works better and doesn't crash as easily as before.


Issues I've run into (and which may cause users to submit problem
reports:

 * Music became loud noise after the first fight. Pulse Audio was
still working fine (i.e. I could start a music player as a test), but
in lordsawar it needed several attempts to make the music return.

 * At the end of a test game (the remaining two enemies surrendered),
confirming "Quit" did not close the game window. I could choose and
confirm Quit again and again, but that didn't help. Killing the process
worked.


The build log contains a few interesting warnings that are worth
an investigation:

gtksdl.c:218: warning: the address of 'SDL_windowhack' will always evaluate as
'
true'
playerlist.cpp:367: warning: deprecated conversion from string constant to
'char
*'
player.cpp:862: warning: suggest parentheses around && within ||


Packaging-wise it's fine.
 * A desktop menu icon could be added.
 * You could use --vendor="" instead of --vendor="fedora" when
installing the .desktop file


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list