[Bug 469471] Review Request: skinlf - Java look and feel for swing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Chitlesh GOORAH <cgoorah at yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgoorah at yahoo.com.au




--- Comment #2 from Chitlesh GOORAH <cgoorah at yahoo.com.au>  2008-11-23 08:00:09 EDT ---
#001: remove the copyright paragraph, else I won't review this package

#002: avoid renaming spec files : %{name}-X.spec. Always keep the spec filenme
as %{name}.spec. I have seen you did the same for all your packages.

#003: rpmlint issues
chitlesh(~)[0]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/skinlf-6.7-2.fc9.i386.rpm
skinlf.i386: W: no-documentation
skinlf.i386: E: description-line-too-long Today many applications must be
skinnable: your CD player, your emailnotifier, even your operating system! Now
with Skin Look And Feel, your Java application is skinnable! Skin Look And Feel
is able to read GTK (The Gimp ToolKit) and KDE (The K Desktop Environment)
Skins to enhance your application GUI controls such as Buttons, Checks, Radios,
Scrollbars, Progress Bar, Lists, Tables, Internal Frames, Colors, Background
Textures, Regular Windows.
skinlf.i386: W: non-standard-group skinlf
skinlf.i386: W: invalid-license Apache
skinlf.i386: E: no-binary

Break the description paragraph into seperate lines.

004: Build errors, possible missing BuildRequires:
     [javac]                       ^                                            
    [javac]
/home/chitlesh/rpmbuild/BUILD/skinlf-6.7/build/src/com/l2fprod/tools/msstyles/MsStylesToSkinLF.java:78:
warning: com.sun.org.apache.xpath.internal.XPathAPI is Sun proprietary API and
may be removed in a future release                                              
    [javac]       (Element)XPathAPI.                                            
    [javac]                ^

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.