[Bug 472848] Review Request: jeuclid-core - MathML rendering solution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472848





--- Comment #2 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-11-25 05:14:04 EDT ---
Some quick notes:

% rpmlint jeuclid-core-*
jeuclid-core.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/jeuclid-core-3.1.3/NOTICE
jeuclid-core.x86_64: W: incoherent-version-in-changelog 3.1.3 ['3.1.3-1.fc9',
'3.1.3-1']

You need to put the package release in a changelog entry, too.

jeuclid-core.x86_64: E: no-binary
jeuclid-core-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 2 warnings.

This should be a noarch package, because it contains no binaries (as rpmlint
tells you). That'll also fix the empty debuginfo. Use BuildArch: noarch.

BuildRequires: java-devel
BuildRequires: java-1.6.0-openjdk-devel

One of these is redundant.

Please add comments to patches, i.e.
# this patch fixes foo, Fedora specific
Patch0:  jeuclid-core-build.patch
# this patch fixes bar, submitted upstream
Patch1:  jeuclid-core-FreeHep.patch

I could sponsor you if you can demonstrate knowledge of our packaging
guidelines, i.e. by submitting another package or two for review and doing a
couple of package reviews.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.