[Bug 473037] Review Request: tcc - small c compiler that can run c scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473037


Conrad Meyer <konrad at tylerc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |konrad at tylerc.org




--- Comment #2 from Conrad Meyer <konrad at tylerc.org>  2008-11-26 03:32:01 EDT ---
Some problems:

Any reason the Summary isn't "Tiny C Compiler"?

You should convert Changelog to UTF-8 during prep, not build. Also, please use
touch -r to keep the original timestamp.

The perl in %install can be trivially replaced with sed, part of the default
build root (i.e. no extra BuildRequire). Also I'm not 100% sure that's doing
the right thing there (probably you mean to replace just the install dir with
DESTDIR+installdir, then pass DESTDIR to the make install?

In %files devel "%{_libdir}/%{name}/*.o" looks *very* wrong to me, the only
things that should include straight object files are cross compilers IMO (maybe
I'm wrong?).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.