[Bug 473046] Review Request: miniupnpc - command line tool to control NAT in UPnP-enabled routers as Linksys, D-Link etc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473046





--- Comment #6 from Fabian Affolter <fabian at bernewireless.net>  2008-11-26 13:40:51 EDT ---
(In reply to comment #5)
> OK, I'll change that. But just be aware that I copied this Source0 line format
> from the official Fedora rdesktop spec file.

The rdesktop spec file is not reviewed so far.  The 'Merge Review' is pending. 
Your Source0 is acceptable if there is no source code available from a
online/upstream location or only out of a VCS.  But in this case it has to be
documented in the spec file.  Basically all source must come from upstream.

> Before I send a new version, I need some guidance with the group. The spec file
> I used as a base had "User Interface/Desktops" but this is not the case for
> this package.
> Where I can find a list of valid groups ?

less /usr/share/doc/rpm-*/GROUPS

> BTW, this FE-NEEDSPONSOR tag is documented somewhere? I couldn't find a single
> line in the documentation about it. I would like to update the documentation to
> include that, after this package is accepted.

See
https://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.