[Bug 473330] Review Request: ecm - Elliptic Curve Method for Integer Factorization

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473330





--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-11-28 15:41:48 EDT ---
 I've just taken a quick glance at a mock build and there are several problems
which must be fixed and also some improvements which I recommend
MUSTFIX: according to the build log (and to your %files section), you are not
compiling the shared libs, but you do compile static libs:
   [...]
   checking whether to build shared libraries... no
   checking whether to build static libraries... yes
+
   %files devel
   %{_libdir}/lib%{name}.a

 You should do the exact opposite (
http://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries
), unless you have a very clear motif (in which case a note should be added to
the spec). Plus, static libs do not go into -devel.rpm but into -static.rpm. If
you need both static and shared, then package both.

MUSTFIX ecm-devel should require the base package

RECOMMENDED  please try to preserve the timestamps of the included files.
probably
   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 
should do


  I have also noticed that configure complains about a missing xsltproc. Is it
intentional or a missing BR?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.