[Bug 463996] Review Request: tuxguitar - A multitrack tablature editor and player written in Java-SWT

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463996





--- Comment #19 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-01 13:45:27 EDT ---
Created an attachment (id=319139)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=319139)
crash log when tuxguitar exits

For 1.0-5:

* Requires
  - I guess at least "Requires: libswt3-gtk2" is missing.

* Using build-classpath
  - For example
--------------------------------------------------------
make SWT_JAR=%{_libdir}/java/swt.jar CFLAGS="${RPM_OPT_FLAGS}
-I%{openjdkdir}/include -I%{openjdkdir}/include/linux -fPIC"
--------------------------------------------------------
    I guess using
--------------------------------------------------------
make SWT_JAR=$(build-classpath swt) CFLAGS=.....
--------------------------------------------------------
    is more portable on Fedora (see:
    https://fedoraproject.org/wiki/Packaging/Java#build-classpath )

    ! Note:
      Usually the environment CLASSPATH is not set by default.
      As far as I see misc/tuxguitar.sh when this script is called
      CLASSPATH seems to be set finally like:
--------------------------------------------------------
:/usr/share/tuxguitar/tuxguitar.jar:/usr/lib/java/swt.jar
--------------------------------------------------------
      Usually any environment value with begin with colon is
      unwilling (same for LD_LIBARARY_PATH)

* Some script improvement
  * desktop-file-install
--------------------------------------------------------
install -pm 644 %{SOURCE9} $RPM_BUILD_ROOT/%{_datadir}/applications/
desktop-file-install --dir $RPM_BUILD_ROOT%{_datadir}/applications
--delete-original $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop
--------------------------------------------------------
  - can be
--------------------------------------------------------
desktop-file-install \
 --dir $RPM_BUILD_ROOT%{_datadir}/applications \
 %{SOURCE9}
--------------------------------------------------------

  * installing hicolor icons
--------------------------------------------------------
for dim in 16x16 24x24 32x32 48x48 64x64 96x96; do
 install -dm 755
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/$dim/apps/%{name}.png
 install -pm 644 TuxGuitar/share/skins/Lavender/icon-$dim.png
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/$dim/apps/%{name}.png
done
--------------------------------------------------------
    "$ rpm -ql tuxguitar" shows unwilling results. This creates
    the directory named "%{_datadir}/icons/hicolor/$dim/apps/%{name}.png"
    and installs icon under the directory.

  * installing mime icons
--------------------------------------------------------
install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-tuxguitar.png
install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-gtp.png
install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-ptb.png
---------------------------------------------------------
  - I guess
---------------------------------------------------------
for type in \
 tuxguitar gtp ptb
 do
 install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png \
  $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-${type}.png
done
---------------------------------------------------------
    is cleaner

* jni
  - jni files must be installed under %_libdir/%name:
    https://fedoraproject.org/wiki/Packaging/Java#Guideline

* desktop database update
  - When installed desktop file contains MimeType key, desktop database
    must be updated:
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database


! By the way it seems I can heard no sound and when I
  close tuxguitar:
---------------------------------------------------------
[tasaka1 at localhost tuxguitar]$ tuxguitar 
fluidsynth: error: The "default" audio device is used by another application
#
# An unexpected error has been detected by Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x032afef2, pid=6874, tid=1616784
#
# Java VM: OpenJDK Client VM (1.6.0_0-b12 mixed mode linux-x86)
# Problematic frame:
# C  [libfluidsynth.so.1+0x14ef2]  delete_fluid_audio_driver+0x22
#
# An error report file with more information is saved as:
# /home/tasaka1/rpmbuild/Reviewing/tuxguitar/hs_err_pid6874.log
#
# If you would like to submit a bug report, please visit:
#   http://java.sun.com/webapps/bugreport/crash.jsp
#
^CMultiple segmentation faults occurred; can't display error dialog
-----------------------------------------------------------
  and hs_err_pid6874.log is attached.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.