[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424


Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?




--- Comment #21 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-10-02 06:09:50 EDT ---
(In reply to comment #17)
> Some notes:
> 
> * EVR
>   - At least EVR (Epoch-Version-Release) needs fixing:

Right, I seem to have missed that. Thanks for noticing.

> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
> 
> * configure
>   - Doesn't the following work?
> -----------------------------------------------------------
> # Single precision
> mkdir single
> cd single
> ln -sf ../configure
> %configure \
>  --disable-rpath --enable-shared \
>  --disable-static --enable-float \
> .......
> -----------------------------------------------------------

Thanks, I was thinking about how to avoid the long versions and this should
work.

> * Namespace in %_bindir, generic names
>   - Your srpm installs many exectables under %_bindir, which is not desired.
>     Also some files has too generic names (like luck, wheel, highway, and so
> on),
>     which is rather a blocker.
>     Please move (almost all) executables under %_bindir to %_libexecdir/%name,
> for
>     example and add executables under %_bindir which are _really_ needed.

You're right. I guess I have to withdraw the approval until we resolve this.
Thanks for catching it.

> * Duplicate files
> -----------------------------------------------------------
> $ rpm -qlp *rpm | sort | uniq -d
> /usr/bin/GMXRC
> /usr/bin/GMXRC.bash
> /usr/bin/GMXRC.csh
> /usr/bin/GMXRC.zsh
> /usr/bin/demux.pl
> ------------------------------------------------------------
>    - Fix these.

Ehhh, this happened after I asked Jussi to move the GMXRC.* scripts to
subpackages and forgot that he had %{_bindir}/* in the main package.

rpmlint should catch such things.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.