[Bug 462251] Review Request: PyMOL - python molecular graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #4 from Gianluca Sforna <giallu at gmail.com>  2008-10-02 06:36:25 EDT ---
(In reply to comment #3)
> > you will need to create the tarball from upstream SVN, documenting the
> > procedure in the spec file (usually the easiest way is to add a small script
> > to compose the tarball). 
> 
> Done.

That's better, but getting sources off the 1.1 branch does not guarantee we can
reproduce the build at any random time in the future because the branch will
likely be modified by bug fix commits.

You need to locate a suitable revision (possibly, but not necessarily, off the
1.1 branch) and pull that one. I failed to note this also imply you need rename
the release tag according to:

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

so the package will be named something like:

pymol-1.1-x.YYYYMMDDsvnREV


> 
> > * There is no need to prepare and fill the docs directory, a single line in 
> > the files section like:
> 
> This was only done since the python setup script does not install the files
> into RPM_BUILD_ROOT.

Yeah, that's normal. But files listed in %doc are picked up from RPM_BUILD_DIR
so it will work (I just tested it locally)

> 
> > * it's the first time I see the sanity check on RPM_BUILD_ROOT before removing
> > it. I can't remember any guideline against it, but I'd avoid it anyway.
> 
> removed.

You removed too much ;) %install and %clean section must start with 
rm -rf ${RPM_BUILD_ROOT}
I was suggesting removing just to the check ${RPM_BUILD_ROOT} != "/"


lastly, mock build still fails due to unpackaged egg-info file, please add 
%{python_sitearch}/*egg-info

to %files. Full details at http://fedoraproject.org/wiki/Packaging/Python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.