[Bug 462982] Review Request: buffer - General purpose buffer program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462982


Bruno Cornec <bruno_cornec at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bruno_cornec at hp.com




--- Comment #10 from Bruno Cornec <bruno_cornec at hp.com>  2008-10-02 11:24:44 EDT ---
(In reply to comment #9)
> I'll take care of this. For the moment there are a few issues:
> 1. major one: during compilation the mandatory gcc flags as imposed by Fedora
> (http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags) are not
> used. Instead compilation is done with  -Wall -O6 -fomit-frame-pointer

Fixed.

> 
> 2. minor issues:
> - I see no point in applying all the debian patches. We have no need for the
> content of the debian folder. You do not package it, which is OK, but I would
> have adjusted the patches to better fit Fedora. Not a blocker, feel free to
> leave it as it is.

I chose to keep the debian specific stuff, in order to be able to easily back
port further Debian patches (which are useful also for the Fedora package) in
the future if needed. Removing the creation of the debian content would make a
different patch.
If it's not a big issue I'd rather keep it like that.

> - there is a missing "s" in the Summary(fr) line (des bande -> des bandes)

Fixed as well.

Please look at ftp://ftp.mondorescue.org/test/fedora/9/buffer.spec and
ftp://ftp.mondorescue.org/test/fedora/9/buffer-1.19-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.