[Bug 462251] Review Request: PyMOL - python molecular graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #6 from Tim Fenn <fenn at stanford.edu>  2008-10-03 23:30:09 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > > you will need to create the tarball from upstream SVN, documenting the
> > > procedure in the spec file (usually the easiest way is to add a small script
> > > to compose the tarball). 
> > 
> > Done.
> 
> That's better, but getting sources off the 1.1 branch does not guarantee we can
> reproduce the build at any random time in the future because the branch will
> likely be modified by bug fix commits.
> 

Fixed.

> 
> > 
> > > * There is no need to prepare and fill the docs directory, a single line in 
> > > the files section like:
> > 
> > This was only done since the python setup script does not install the files
> > into RPM_BUILD_ROOT.
> 
> Yeah, that's normal. But files listed in %doc are picked up from RPM_BUILD_DIR
> so it will work (I just tested it locally)
> 

Ah, I didn't have them listed as %doc before - fixed this.

> > 
> > > * it's the first time I see the sanity check on RPM_BUILD_ROOT before removing
> > > it. I can't remember any guideline against it, but I'd avoid it anyway.
> > 
> > removed.
> 
> You removed too much ;) %install and %clean section must start with 
> rm -rf ${RPM_BUILD_ROOT}
> I was suggesting removing just to the check ${RPM_BUILD_ROOT} != "/"
> 

Whoops - fixed.

> 
> lastly, mock build still fails due to unpackaged egg-info file, please add 
> %{python_sitearch}/*egg-info
> 
> to %files. Full details at http://fedoraproject.org/wiki/Packaging/Python

I followed https://fedoraproject.org/wiki/Packaging/Python/Eggs to properly set
up the egg-info files.

new spec url: http://www.stanford.edu/~fenn/packs/pymol.spec
srpm url:
http://www.stanford.edu/~fenn/packs/pymol-1.1-3.20080912svn3419.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.