[Bug 461131] Review Request: sim - Simple Instant Messenger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461131





--- Comment #46 from Patrice Dumas <pertusus at free.fr>  2008-10-06 19:03:11 EDT ---
(In reply to comment #45)
> (In reply to comment #44)
> > Shouldn't kde supportr be build in the default case?
> > That would mean using
> > 
> > %bcond_with kde
> Yes, off course. Why we may want disable kde support by default?

Crap, I said the reverse of the correct thing. To have it defaulted to true, it
should be:

%bcond_without kde

> > Now the %post -p isn't used anymore
> By link what you provided befor it is mentioned as alternative.

It is not a problem, in fact you have to do it that way.

> > you have to add explicitely:
> > 
> > Requires(postun): /sbin/ldconfig
> > Requires(post): /sbin/ldconfig
> Hm... Sure? Din not /sbin/ldconfig generic??

Think about install in chroots and more importantly installation order.

> In most cases, in package descriptions and other I'm wrap text in width of 80
> characters...
> I will try to be careful in the future.

In %description it is not a suggestion, it is a must, but you made it right.
But there are other places in th espec where you don't do it (in the tags part,
in %changelog...). Still it is only a suggestion in these places.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.