[Bug 462251] Review Request: PyMOL - python molecular graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462251





--- Comment #18 from Tim Fenn <fenn at stanford.edu>  2008-10-07 15:08:54 EDT ---
(In reply to comment #12)
> > # The source for this package was pulled from upstream's vcs.  Use the
> > # following commands to generate the tarball:
> > #  svn co https://pymol.svn.sourceforge.net/svnroot/pymol/branches/b11/pymol pymol-1.1
> > #  tar cvzf pymol-1.1-20080912svn3419.tar.gz pymol-1.1
> > Source0: pymol-1.1-20080912svn3419.tar.gz
> 
> - More exactly:
> svn co -r 3419
> https://pymol.svn.sourceforge.net/svnroot/pymol/branches/b11/pymol pymol-1.1
> 

Done.

> 
> - Group: Development/Tools
> 
> Wouln't Applications/Engineering be a better choice? This is a atomistic
> visualisation program, after all. (Applications/Science would of course be
> better if it existed..)
> 

Changed to Applications/Engineering

> - Separate BuildRequires and Requires should be made for each required package. 
> 

Done according to https://bugzilla.redhat.com/show_bug.cgi?id=462251#c17

> 
> - export RPM_OPT_FLAGS="-O2"
> 
> Is there some reason not to use %optflags?
> 

Fixed.

spec url: http://www.stanford.edu/~fenn/packs/pymol.spec
srpm url:
http://www.stanford.edu/~fenn/packs/pymol-1.1-5.20080912svn3419.f8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.