[Bug 463211] Review Request: notify-sharp - A C# implementation for Desktop Notifications

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 9 21:59:01 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463211





--- Comment #14 from Paul F. Johnson <paul at all-the-johnsons.co.uk>  2008-10-09 17:59:00 EDT ---
#12 -

The docs should be in their own subpackage. It doesn't matter if there is only
one file in the -devel subpackage, the guidelines say that the .pc file should
be in the -devel subpackage, so there it goes. Quite a few mono -devel
subpackages only contain the .pc file (mono-basic generates it's own from the
spec file)

The patch is also not really required

sed -i -e 's!${exec_prefix}/lib!%{_libdir}!' notify-sharp.pc.in

should fix the problem with minimal fuss

#13 -

You need to remove the smp_mflags from the build script (it should fix the
problem). Again, mono apps don't always like smp_mflags being set (monodevelop
really gets upset at parallel builds going on).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list