[Bug 456256] Review Request: frei0r-plugins - Frei0r - a minimalistic plugin API for video effects

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 10 18:57:44 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456256


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net
               Flag|                            |fedora-review?




--- Comment #1 from Jon Ciesla <limb at jcomserv.net>  2008-10-10 14:57:42 EDT ---
rpmlint clean on SRPM.

on RPMS:
frei0r-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix, if applicable.

Mightn't we want to call frei0r-devel frei0r-plugins-devel, since the base
pacakge is frei0r-plugins?

License is good, but I hope gavl turns out to be GPLv2.

What's the status of the patches WRT upstream?

Do we not need ldconfig in the post/postun for the main package?

Otherwise looks good, waiting on libgdither and gavl for a mock build to test
BRs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list