[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




--- Comment #1 from Patrice Dumas <pertusus at free.fr>  2008-10-10 17:16:55 EDT ---
I can't see why you don't use the initial Makefile. Something along

make CC="%__cc" CFLAGS="$RPM_OPT_FLAGS" LIBS="-lcrpyto" chntpw cpnt reged

And use simple cp or install to install the resulting executables.

Using cmake while upstream doesn't seems too much to me.

openssl in requires is not useful, it is automatically found by rpm.

It is better to avoid using Fedora whenever possible, so please rename
README.Fedora to something more neutral like README.Dist

cp should be cp -p to keep timestamp.

Also I suggest using 
%{_mandir}/man8/%{name}.8*
to catch any kind of compression.

I am afraid that, if accepted, you'll need contact legal (through spot,
he is the contact) because of the crypto and export stuff.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.