[Bug 466394] Review Request: pdf-renderer - A 100% Java PDF renderer and viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466394





--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-11 03:25:28 EDT ---
Okay. Now one issue and one question

* License
  - Since you completely removed .pfb files from tarball, the license can be
    simply "LGPLv2+".

? XXXX.length in BaseFonts.properties
  - One question is that BaseFonts.properties contains lines like the
    following:
------------------------------------------------------------------
Courier-Bold.length=120373
------------------------------------------------------------------
    However on my system n022004l.pfb has 101592 bytes.
    Can these difference of size be ignored?
    If not (i.e. size should also be fixed), the following sample scripts
    may be useful.
------------------------------------------------------------------
#!/bin/sh

INPUT=BaseFonts.properties
OUTPUT=BaseFonts.properties.1

FONTDIR=/usr/share/fonts/default/Type1

rm -f $OUTPUT
cat $INPUT | while read line
 do
 newline=$line
 if echo $newline | grep -q 'file=.*pfb'
  then
  pfbname=$(echo $newline | sed -e 's|^.*file=||')
  newline=$(echo $newline | sed -e "s|file=|file=${FONTDIR}/|")
 elif echo $newline | grep -q 'length='
  then
  size=$(ls -al ${FONTDIR}/$pfbname | awk '{print $5}')
  newline=$(echo $newline | sed -e "s|length=.*|length=$size|")
 fi
 echo $newline >> $OUTPUT
done
-------------------------------------------------------------------
   (When size needs fixing and you use this script, "BuildRequires: urw-fonts"
    is needed to examine the size of the installed fonts)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.