[Bug 455953] Review Request: rakarrack - Audio effects processing rack for guitar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455953





--- Comment #8 from David Timms <dtimms at iinet.net.au>  2008-10-11 22:53:49 EDT ---
(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> Thanks! But I need to correct myself here. 
>    %{__mkdir} -p %{buildroot}%{_datadir}/icons/hicolor/$dim/apps
>    %{__mv} %{buildroot}%{_datadir}/pixmaps/icono_rakarrack_$dim.png \
>         %{buildroot}%{_datadir}/icons/hicolor/$dim/apps/rakarrack.png
> 
> would be better. None of the existing icons I saw in hicolors/$dim/apps/ are
> named as application.$dim.png . They are all named as application.png . Let's
> keep the thing as they are.
Yes, reading freedesktop .desktop spec says that preferably the icon should be
just name, and the app can then choose either an svg, or most appropriate size
png. Giving this a go.

> You can overwrite the existing .desktop file with %Source1 after "make install"
> so there won't be an ambiguity. I think the final .desktop file in the RPM
> should be named rakarrack.desktop (not rakarrack-fedora.desktop , this would be
> unusual!).
Actually, the typical names from what I can see are fedora-rakarrack.desktop.
This seems to be based on the vendor tag. The vendor item has been removed from
the desktop-file-install command.

> In the spec file, avoid using %macros directly inside comments and changelogs.
> e.g. this is WRONG:
I'll keep an eye out for my attempted quick comments ;-)

> I recommend using the %{name} macro instead of hardcoding the name of the
> application into the spec file; i.e. in this case replacing the occurrences of
> rakarrack * with %{name} is the preferred way. Same thing applies for the
> %{version} macro.
Done.

OK. Finally got the sed and echo mods to the desktop file to work correctly:
Updated spec: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack.spec
New .src.rpm:
http://members.iinet.net.au/~timmsy/rakarrack/rakarrack-0.2.0-3.fc9.src.rpm

* Sun Oct 12 2008 David Timms <iinet.net.au @ dtimms> - 0.2.0-3
- don't exclude the original .desktop file

* Mon Oct 06 2008 David Timms <iinet.net.au @ dtimms> - 0.2.0-2
- mod icon names to be appname.png to fit with fallback desktop spec
- replace rakarrack with name macro
- mod .desktop via sed and cat, rather than additional Source file
- add .desktop extra categories using the desktop-file-install utils

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.