[Bug 465372] Review Request: chntpw - Change passwords in Windows SAM files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465372


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
               Flag|                            |fedora-review+




--- Comment #11 from Patrice Dumas <pertusus at free.fr>  2008-10-12 05:32:51 EDT ---
* rpmlint is silent
* follow guidelines
* free software, license included
* match upstream:
09addfe7ae469677da39ed66d83858d3  chntpw-source-080526.zip
* %files section right


Just one suggestion, I think it is better to use sed for the
end of line, and to keep timestamp, like:

sed -e 's/\r$//' WinReg.txt > WinReg.txt.eol
touch -c -r WinReg.txt WinReg.txt.eol
mv WinReg.txt.eol WinReg.txt

This is only asuggestion, so

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.