[Bug 459631] Review Request: insight - GDB debugger GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459631


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review+




--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-12 11:35:50 EDT ---
Well,

* Desktop Categories
  - The Categories "Application" "X-Fedora" are now deprecated
    and should be removed.
    (To remove "Application", you can add "--remove-category=Application"
     option to desktop-file-utils)

* Timestamps
  - Please consider to use
---------------------------------------------------------
make install DESTDIR=${RPM_BUILD_ROOT} INSTALL="install -p"
---------------------------------------------------------
    to keep timestamps on files to be installed as much
    as possible.
    This method usually works for Makefiles generated by 
    recent autotools.

! Other things are okay
- license correct (GPLv3+)
- builds successfully, build log good
- spec description good
- can be installed
- _seems_ to work

---------------------------------------------------------
   This package (insight) is APPROVED by mtasaka
---------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.