[Bug 465381] Review Request: sugar-moon - Lunar Activity for the sugar desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465381


Simon Schampijer <simon at schampijer.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon at schampijer.de
               Flag|                            |fedora-review?




--- Comment #2 from Simon Schampijer <simon at schampijer.de>  2008-10-14 07:05:14 EDT ---
Great, thanks for your work!

Some little things:

We do not need that:
%define sugaractivitydir /usr/share/sugar/activities/
%define sugarlibdir %{_libdir}/sugar/activities

The License is GPLv2+
License: GPLv2+

A visual nitpick, I think you do not need the tabs at the header, example:

Name: sugar-moon
Version: 8
Release: 1%{?dist}
Summary: Moon phases activity for sugar

Group:  Sugar/Activities
License: GPLv2+
BuildArch: noarch
URL: http://wiki.laptop.org/go/Moon

here you should add your email address:
* Mon Oct 13 2008 Bryan Kearney <email address> - 8-1

The warning is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.