[Bug 452107] Review Request: cfdg - Context Free Design Grammar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452107





--- Comment #10 from Terje Røsten <terjeros at phys.ntnu.no>  2008-10-14 17:26:36 EDT ---
Add this patch:

--- ContextFreeSource2.1.orig/Makefile  2007-04-29 07:51:20.000000000 +0200
+++ ContextFreeSource2.1/Makefile       2008-10-14 23:12:11.000000000 +0200
@@ -102,8 +102,9 @@
 # Rules
 #

+OPTFLAGS = -03
 CPPFLAGS += $(patsubst %,-I%,$(INC_DIRS))
-CPPFLAGS += -O3
+CPPFLAGS += $(OPTFLAGS)
 #CPPFLAGS += -ggdb

 $(OBJ_DIR)/%.o : %.cpp

Aand change

make CFLAGS+="$RPM_OPT_FLAGS"
 to
make OPTFLAGS="%{optflags}"

BTW: don't mix $ style and % style macros.

This

mkdir -p %{buildroot}%{_bindir}
install -m 755 cfdg %{buildroot}%{_bindir}/cfdg

could be one line:

install -D -m 755 cfdg %{buildroot}%{_bindir}/cfdg

Add smp_flags to make.

Very picky:

-create. should be - Create.

 http://www.contextfreeart.org/index.html

->  http://www.contextfreeart.org/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.