[Bug 462163] Review Request: checkdns - A Domain Name Server analysis and reporting tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462163


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #7 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-10-15 19:40:04 EDT ---
A couple of remarks, before the full review
- the correct license is GPLv2+. All files that include a license in the header
specify, and I quote:
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.
- the compilation flags which are mandatory for Fedora are ignored. Please make
sure that the make process uses %{optflags}
- I did not examine carefully the program, but I think that you can eliminate
the need of suid group for the checkdns folder if - in %post - you create a
checkdns user and use
     chown checkdns.apache  /var/www/html/checkdns
     chmod 755 /var/www/html/checkdns
     make sure that the checkdns program is run as the checkdns user (which is
             extremely easy to do in cron)
The only drawback is that if the program is run by another user (in a console),
the HTML files will not be created with the correct ownership. But as the
output is sent to the console, it can be redirected anywhere.
- in addition to the above, I urge you to install an example cron file, either
in /var/spool/cron/checkdns (make sure you match the user created above) or in
/etc/cron.d (in which case make sure you specify the user that the script runs
as, for instance:
     # Runs the chkdns periodic check
     17 01 * * * checkdns /bin/checkdns 1> /dev/null 2> /dev/null
once again, the user after the time fields must match the one created in %post

- feel free to drop the TODO file, it's useless in the current form. However,
leave it in if you think that it might contain something useful in the
foreseeable future

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.