[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <dennis at ausil.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dennis at ausil.us




--- Comment #11 from Dennis Gilmore <dennis at ausil.us>  2008-10-16 09:43:28 EDT ---
have a look at
http://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_in_certain_situations
 i think you should only run the %pre and %post scriptlets on install rather
than checking each time if things are there or not.

you should also remove %define doc_dir %{_docdir}/%{name}  and mkdir -p
$RPM_BUILD_ROOT%{doc_dir}
  from the spec file.  its not needed.

you can and should post a tarball on fedorahosted. please do so and use the
full url to the upstream source.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.