[Bug 467293] Review Request: scummvm-tools - Tools for scummVM / S.C.U.M.M scripting language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467293





--- Comment #2 from Lucian Langa <cooly at gnome.eu.org>  2008-10-17 04:55:52 EDT ---
(In reply to comment #1)
> * The description needs to be descriptive.
updated description


> *  Won't you need
>    Requires: scummvm = %version
> instead of
>    Requires: scummvm >= 0.12.0
fixed


> * License should be GPLv2+ as told by the source files.
updated license


> * In the .desktop file 
>   - put a "Generic Name:" with a very brief description. 
>   - also it would be more comlpliant with the existing ScummVM package if you
> make the "Name: ScummVM Tools".
>   - afaik you shouldn't have Application as a category in a .desktop file.
fixed


> * Compiler flags need to be appropriate. This is C++ code, so in order to honor
> Fedora specific compilation flags you will most likely need to play with the
> CXXFLAGS. Make sure they are not overridden by the other CXXFLAGS in the
> Makefile. You shouldn't set CFLAGS as it is irrelevant for this package.
fixed


> * Did you submit the patch upstream?
patch submitted upstream


Spec URL: http://lucilanga.fedorapeople.org/scummvm-tools.spec
SRPM URL: http://lucilanga.fedorapeople.org/scummvm-tools-0.12.0-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.