[Bug 466829] Review Request: openalchemist - reflexion game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466829


Alexey Torkhov <atorkhov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Alexey Torkhov <atorkhov at gmail.com>  2008-10-18 13:08:30 EDT ---
REVIEW:

+ rpmlint output is ignorable:

openalchemist.i386: W: devel-file-in-non-devel-package
/usr/bin/openalchemist-config

+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license
(GPLv2+ and CC-BY-SA).
+ File, containing the text of the licenses for the package is included in
%doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package must matches the upstream source, as
provided in the spec URL.

3107b699d63d5ae7cbf65ddc9872c49a  openalchemist-0.3-src.tar.gz
3107b699d63d5ae7cbf65ddc9872c49a  openalchemist-0.3-src.tar.gz.orig

+ The package successfully compiles and builds into binary rpms on at least
one supported architecture (x86).
+ All build dependencies are listed in BuildRequires.
+ No need to deal with locales.
+ Does not contain shared libraries.
+ The package does not designed to be relocatable.
+ A package owns all directories that it creates.
+ A package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
+ The package consistently uses macros, as described in the macros section of
Packaging Guidelines.
+ The package contains code, or permissable content.
+ Does not contain large documentation files.
+ Includes only doc files in $doc.
+ No headers.
+ No static libraries.
+ The package does not contain pkgconfig(.pc) files.
+ The package does not contain library files with a suffix (e.g.
libfoo.so.1.1).
+ No devel packages.
+ The package does not contain any .la libtool archives.
+ Includes .desktop file. Properly installed with desktop-file-install.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT.
+ All filenames in the package are valid UTF-8.


This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.