[Bug 244192] Review Request: eclipse-anyedit - AnyEdit plugin for Eclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=244192


Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




--- Comment #36 from Andrew Overholt <overholt at redhat.com>  2008-10-20 12:50:05 EDT ---
I had a nice review all typed up but I accidentally hit Ctrl-W :(  Sorry if
this is ugly:

- I don't think you want to include the LICENSE file - just talk to upstream
about putting it directly into their JAR
- the Source0 URL seems incorrect.  However, if I use the URL provided at the
upstream site, the md5sums match
- take care of the changes in #35
- move the JAR to %{_datadir}/eclipse/dropins and not %{_libdir}
- please document the package.xml and assemble.xml files (how you created them,
etc.)
- did you talk to Andrei about the unicode issue?  maybe just document where
the bug lies

- package builds and functions fine on x86_64
- rpmlint output:

$ rpmlint ../SRPMS/eclipse-anyedit-2.1.1-3.fc9.src.rpm 
eclipse-anyedit.src:121: W: libdir-macro-in-noarch-package %attr(-,root,root)
%{_libdir}/gcj/%{name}
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint ../RPMS/noarch/eclipse-anyedit-2.1.1-3.fc9.noarch.rpm 
eclipse-anyedit.noarch: E: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

^ This is caused by the location of the JAR.  Moving to %{_datadir} will fix
it.

$ rpm -qlp !$
rpm -qlp ../RPMS/noarch/eclipse-anyedit-2.1.1-3.fc9.noarch.rpm
/usr/lib64/eclipse/dropins/anyedit/plugins/de.loskutov.anyedit.AnyEditTools_2.1.1.200809292108.jar
/usr/share/doc/eclipse-anyedit-2.1.1
/usr/share/doc/eclipse-anyedit-2.1.1/LICENSE

Other than the location of the JAR, things are fine here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.