[Bug 466688] Review Request: mpfi - An interval arithmetic library based on MPFR

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 20 19:53:31 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466688


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pertusus at free.fr
               Flag|                            |fedora-review+




--- Comment #13 from Patrice Dumas <pertusus at free.fr>  2008-10-20 15:53:29 EDT ---
* rpmlint is silent
* free software, upstream includes wrong license, so license file not shipped
* match upstream
02f3fb7a09ef683f035dd20dca653507  mpfi-1.3.4-RC3.tar.gz
* follow packaging guidelines
* static library rightly packaged
* %files section right

please keep the timestamp of archives (with spectool -g or wget -N for
example):
-rw-rw-r-- 1 dumas dumas 150760 oct. 20 21:48 mpfi-1.3.4-RC3.tar.gz
-rw-r--r-- 1 dumas dumas 150760 oct. 12 21:11 ../SOURCES/mpfi-1.3.4-RC3.tar.gz

If source timestamp is kept
APPROVED


You should contact upstream about the license file mismatch.

Also wait something like a day to let Ralf comment if he wants to.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list