[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=447456





--- Comment #15 from Denis Leroy <denis at poolshark.org>  2008-10-21 03:27:02 EDT ---
- License is GPLv2+
- rpmlint ok
- spec file is good
- source md5sum good
- packages build
- utilities function correctly , i386 and x86_64


2 minor things:

- according to guidelines, "--vendor=fedora" should be used for
desktop-file-install

- the %files section could be written with just 3 lines:
  %{_datadir}/gupnp-tools
  %{_bindir}/gupnp*
  %{_datadir}/applications/*.desktop


If you're ok with the patch I submitted, consider the package APPROVED. I've
tested the package on F-9 x86_64 and F10 i386.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.