[Bug 467530] Review Request: ladvd - CDP/LLDP sender for unix

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 23 02:14:34 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467530





--- Comment #2 from Andreas Thienemann <andreas at bawue.net>  2008-10-22 22:14:33 EDT ---
Hello Paulo,

thanks for the practice review. If you wanna make it official, go ahead, I do
not need a sponsor so any regular packager can do an official review.

A note about the cflags. Please do take a closer look at the build output. The
way I'm seeing it, the cflags are honored correctly:

[athienem at localhost ladvd]$ rpmbuild -bc ladvd.spec > log 2>&1
[athienem at localhost ladvd]$ rpm --showrc | grep -i cflags
optflags              : %{__global_cflags} -m64 -mtune=generic
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS; 
-14: __global_cflags -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; 
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; 
-11: optflags %{__global_cflags} -m64 -mtune=generic
[athienem at localhost ladvd]$ grep -c -- '-O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4' log 
10
[athienem at localhost ladvd]$ grep -- '-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector --param=ssp-buffer-size=4' log 
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
+ CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
+ FFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT main.o -MD -MP -MF
".deps/main.Tpo" -c -o main.o main.c; \
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT util.o -MD -MP -MF
".deps/util.Tpo" -c -o util.o util.c; \
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT sysinfo.o -MD -MP -MF
".deps/sysinfo.Tpo" -c -o sysinfo.o sysinfo.c; \
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT netif.o -MD -MP -MF
".deps/netif.Tpo" -c -o netif.o netif.c; \
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT cdp.o -MD -MP -MF
".deps/cdp.Tpo" -c -o cdp.o cdp.c; \
if gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -MT lldp.o -MD -MP -MF
".deps/lldp.Tpo" -c -o lldp.o lldp.c; \
gcc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall   -o ladvd  main.o util.o
sysinfo.o netif.o cdp.o lldp.o  -lcap 
[athienem at localhost ladvd]$ 

Just as a note for the next review: The trick here is that for most software
using autotools (configure etc.), the cflags do not have to be specified during
the make call as the environment variable was set during execution of the
%configure macro and the fedora specific cflags were picked up on then.

But thanks nevertheless for the quick review.

regards,
 andreas

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list