[Bug 460660] Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460660





--- Comment #5 from Christopher Stone <chris.stone at gmail.com>  2008-10-23 15:46:44 EDT ---
==== REVIEW CHECKLIST ====

X rpmlint output:
php-pear-Auth-radius.noarch: W: no-documentation
php-pear-Auth.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line
12)
php-pear-Auth-samba.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Please remove all tabs from the spec file.

- package named according to package naming guidelines
- spec file name matches %[name}
- package meets packaging guidelines
- licensed under an approved fedora license
- %license matches actual license
X license file not included in %doc
- spec file written in American English
- spec file legible
- sources match upstream
8d482ac5b07ed74ab8f29430063c6bae  Auth-1.6.1.tgz
8d482ac5b07ed74ab8f29430063c6bae  ../SOURCES/Auth-1.6.1.tgz
- SRPM compiles on x86_64 F-9
- all build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- no duplicate files in %files
- file permissions set properly
- contains a proper %clean section
- macro usage is consistent
- contains code or permissible content
- no large documentation
- no header files
- no static libraries
- no pkgconfig files
- no .so files
- subpackages properly require parent package
- no libtool archives
- not a GUI application
- package does not own files or directories owned by other packages
- buildroot removed in %install
- all files valid utf-8


*** APPROVED ***

==== MUST FIX ====
- No items

==== SHOULD FIX ====
- Remove tabs from spec file
- Add a copy of the PHP license to %doc (see spec file for php-pear-File for an
example)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.