[Bug 468517] Package Review: saoimage - Utility for displaying astronomical images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468517





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-25 13:56:28 EDT ---
Created an attachment (id=321519)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=321519)
Comment for Patch2

Some notes for 1.35.1-1:

* License
  - Well as far as I checked the whole code I only find codes
    under
    * license written in "COPYING" (Copyright only)
    * LGPLv2+ (e.g. fitsfile.c)
    So the license tag should be "LGPLv2+".
    Also add some files to %doc which indicates LGPL license.

* Source origin
  - Would you write where you obtained %SOURCE3?

* About saoimage-1.35.1-mkstemp.patch
  - See attached.

* BuildRequires
  - In your srpm "BuildRequires: desktop-file-utils" is missing
    (while the spec file on the URL you posted here has it)

* %install script
  - What is the line below for?
-------------------------------------------------------------
install -d $RPM_BUILD_ROOT/dev
-------------------------------------------------------------

* XML file
  - I guess this should be installed under %_datadir/mime/packages

* Directory ownership issue
  - The directory %_datadir/mime must not be owned by this
    package.


By the way:
[tasaka1 at localhost saoimage]$ gdb saoimage
GNU gdb Fedora (6.8-15.fc10)
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i386-redhat-linux-gnu"...
(gdb) run
Starting program: /usr/bin/saoimage 
open error: No such file or directory
ERROR: unable to open /dev/imt1o
Error: No remote input possible.

 Smithsonian Astrophysical Observatory image utility
 SAOimage 1.35.1 1 December 2003, Doug Mink, dmink at cfa.harvard.edu

Reserved 512 x 512 image data buffer.

Program received signal SIGSEGV, Segmentation fault.
0x0807bf89 in init_window_basics (border_pixel=0) at wndwinit.c:201
201       (void)XDestroyImage(ximage);
Missing separate debuginfos, use: debuginfo-install libXau.i386 libXcursor.i386
libXdmcp.i386 libXfixes.i386 libXrender.i386
(gdb) thread apply all bt
(gdb) bt
#0  0x0807bf89 in init_window_basics (border_pixel=0) at wndwinit.c:201
#1  0x0807bfd1 in init_windows2 () at wndwinit.c:97
#2  0x0806bded in init_packages (argc=1, argv=0xbffff3e4) at maininit.c:206
#3  0x0806bf44 in main (argc=1, argv=0xbffff3e4) at maininit.c:118
(gdb) qui
The program is running.  Exit anyway? (y or n) y
[tasaka1 at localhost saoimage]$ exit

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.