[Bug 466737] Review Request: matio - Library for reading/writing Matlab MAT files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466737


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #5 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-26 09:37:09 EDT ---
1. Why don't you have just one patch for the fortran-related stuff? Remove
commented sed line.

2. To my understanding you don't need the zlib patch, since you require zlib >=
1.2.3 (the bug is only present in zlib 1.2.2). Remove patch0.

3. Remove all rpath related stuff, matio builds fine without them.

4. Please don't delete man files - rename them all to begin with, say matio-.

5. Add requires:
%if 0%{?fedora} > 8
BuildRequires:  texlive-latex
%else
BuildRequires:  tetex-latex
%endif

and get rid of the doxygen stuff in the spec file.

6. Move PDF to builddir and add it in %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.