[Bug 435016] Review Request: mmdb - MMDB coordinate library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=435016


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #20 from Jason Tibbitts <tibbs at math.uh.edu>  2008-10-26 22:37:19 EDT ---
OK, the tarball matches what I get from the upstream web site now.

rpmlint has grown a new complaint:
  mmdb.x86_64: W: shared-lib-calls-exit /usr/lib64/libmmdb.so.0.0.0 
   exit at GLIBC_2.2.5
I didn't see this last time, which implies that either you had fixed the two
places where exit() is called in the your modified tarball or that rpmlint has
grown this complaint recently.  There was an rpmlint update three days ago so
that might be it.

In any case, this is a rather odd thing for a shared library to do; I'd expect
abnormal exits to call abort() instead, assuming they actually need to stop
program execution.  Obviously you wouldn't expect any normal exits from library
code, but upstream software authors often do rather dumb things.  I don't
really see this as a blocker, however; it's more something that should be
reported as a bug upstream.

In any case, the issues I raised earlier are fixed, and the above isn't a
blocker, I'd say we're done.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.