[Bug 225887] Merge Review: hicolor-icon-theme

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 27 04:27:41 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225887


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orcanbahri at yahoo.com




--- Comment #2 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-27 00:27:40 EDT ---
This package has been around forever. But let's make it match the guidelines.
Here are my notes:

* The URL in the SPEC file needs fixed. The new URL is
http://icon-theme.freedesktop.org/wiki/HicolorTheme

* It would be better if the file Changelog is included in the RPM.

* Disttag is missing. Is there a particular reason?

* The two
   exit 0
lines seem unnecessary.

Well, that's pretty much it :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Fedora-package-review mailing list